OCPBUGS-63354: Increase Node ISO creation timeout from 15 to 30 minutes #2119

mhanss · 2025-10-21T13:13:59Z

This PR increases the timeout for Node ISO creation from 15 minutes to 30 minutes.

openshift-ci-robot · 2025-10-21T13:14:09Z

@mhanss: This pull request references Jira Issue OCPBUGS-63354, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mhanss

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR increases the timeout for Node ISO creation from 15 minutes to 30 minutes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-10-21T13:14:22Z

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: mhanss.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@mhanss: This pull request references Jira Issue OCPBUGS-63354, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)

bug target version (4.21.0) matches configured target version for branch (4.21.0)

bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mhanss

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR increases the timeout for Node ISO creation from 15 minutes to 30 minutes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

coderabbitai · 2025-10-21T13:14:40Z

Walkthrough

Replaced two 15-minute wait.PollUntilContextTimeout timeouts with a new nodeJoinerPollTimeout constant set to 30 minutes in the node image creation workflow, extending poll durations used during node-joiner pod execution and workflow monitoring.

Changes

Cohort / File(s)	Change Summary
Timeout Configuration Update `pkg/cli/admin/nodeimage/create.go`	Added `nodeJoinerPollTimeout = 30m`; replaced two occurrences of 15-minute timeouts in `wait.PollUntilContextTimeout` calls (in `nodeJoinerPodExec` and `monitorWorkflowReport`) with `nodeJoinerPollTimeout`

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Areas to spot-check: nodeJoinerPodExec and monitorWorkflowReport call sites in pkg/cli/admin/nodeimage/create.go to ensure the new constant is used consistently and timeout semantics remain correct.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The pull request title "OCPBUGS-63354: Increase Node ISO creation timeout from 15 to 30 minutes" is fully aligned with the changeset, which added a new nodeJoinerPollTimeout constant set to 30 minutes and replaced hardcoded 15-minute timeouts with this new constant. The title is specific, clear, and accurately describes the primary change without unnecessary noise or vague terms. A teammate scanning the history would immediately understand that this PR increases a timeout value from 15 to 30 minutes.
Description Check	✅ Passed	The pull request description "This pull request increases the timeout for Node ISO creation from 15 minutes to 30 minutes" is directly related to the changeset and accurately describes the modifications made. The description matches the title and clearly conveys what was changed, with sufficient clarity regarding the timeout adjustment even if it lacks implementation details. This meets the lenient criteria for the description check.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 0e39ed6 and 6c04d0a.

📒 Files selected for processing (1)

pkg/cli/admin/nodeimage/create.go (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

pkg/cli/admin/nodeimage/create.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between e6eeeb7 and 0e39ed6.

📒 Files selected for processing (1)

pkg/cli/admin/nodeimage/create.go (1 hunks)

pkg/cli/admin/nodeimage/create.go

andfasano · 2025-10-21T13:17:57Z

/approve

mhanss · 2025-10-21T19:18:53Z

/verified bypass

openshift-ci-robot · 2025-10-21T19:19:06Z

@mhanss: The verified label has been added.

In response to this:

/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pkg/cli/admin/nodeimage/create.go

openshift-ci · 2025-10-27T13:11:42Z

@mhanss: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	`6c04d0a`	link	false	`/test okd-scos-e2e-aws-ovn`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

zaneb · 2025-11-10T21:51:17Z

/lgtm

openshift-ci · 2025-11-10T21:51:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, mhanss, zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/cli/admin/nodeimage/OWNERS~~ [andfasano,zaneb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mhanss · 2025-11-11T07:23:27Z

/verified bypass

openshift-ci-robot · 2025-11-11T07:23:38Z

@mhanss: The verified label has been added.

In response to this:

/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-11-11T10:41:37Z

/retest-required

Remaining retests: 0 against base HEAD 1c5f490 and 2 for PR HEAD 6c04d0a in total

openshift-ci-robot · 2025-11-11T13:31:30Z

@mhanss: Jira Issue Verification Checks: Jira Issue OCPBUGS-63354
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-63354 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

This PR increases the timeout for Node ISO creation from 15 minutes to 30 minutes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2025-11-13T14:39:24Z

Fix included in accepted release 4.21.0-0.nightly-2025-11-13-042845

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 21, 2025

openshift-ci bot requested review from rwsu and zaneb October 21, 2025 13:15

coderabbitai bot reviewed Oct 21, 2025

View reviewed changes

pkg/cli/admin/nodeimage/create.go Outdated Show resolved Hide resolved

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 21, 2025

rwsu suggested changes Oct 21, 2025

View reviewed changes

pkg/cli/admin/nodeimage/create.go Outdated Show resolved Hide resolved

openshift-ci bot assigned rwsu Oct 21, 2025

Increase Node ISO creation timeout from 15 to 30 minutes

6c04d0a

mhanss force-pushed the increase-time branch from 0e39ed6 to 6c04d0a Compare October 27, 2025 09:06

openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Oct 27, 2025

openshift-ci bot assigned zaneb Nov 10, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 11, 2025

openshift-merge-bot bot merged commit 4d35590 into openshift:main Nov 11, 2025
16 of 17 checks passed

OCPBUGS-63354: Increase Node ISO creation timeout from 15 to 30 minutes #2119

OCPBUGS-63354: Increase Node ISO creation timeout from 15 to 30 minutes #2119

Conversation

mhanss commented Oct 21, 2025

Uh oh!

openshift-ci-robot commented Oct 21, 2025

Uh oh!

openshift-ci bot commented Oct 21, 2025

Uh oh!

coderabbitai bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

andfasano commented Oct 21, 2025

Uh oh!

mhanss commented Oct 21, 2025

Uh oh!

openshift-ci-robot commented Oct 21, 2025

Uh oh!

Uh oh!

openshift-ci bot commented Oct 27, 2025

Uh oh!

zaneb commented Nov 10, 2025

Uh oh!

openshift-ci bot commented Nov 10, 2025

Uh oh!

mhanss commented Nov 11, 2025

Uh oh!

openshift-ci-robot commented Nov 11, 2025

Uh oh!

openshift-ci-robot commented Nov 11, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 11, 2025

Uh oh!

openshift-merge-robot commented Nov 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

coderabbitai bot commented Oct 21, 2025 •

edited

Loading